pan3793 commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446742099
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -27,7 +27,7 @@
public class ExecutorDiskUtils {
- private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile(File.separator + "{2,}");
+ private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile("[/\\\\]+");
Review comment:
As before implement, assume all path sep is `/`, only over 2 `/` should
be replaced by `/`. But now, consider the path `/a\b/\c` on Windows, the single
`/` also should be replaced
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
