HeartSaVioR commented on a change in pull request #28930:
URL: https://github.com/apache/spark/pull/28930#discussion_r446775390
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
##########
@@ -55,6 +54,13 @@ object FileStreamSink extends Logging {
}
}
+ def getMetadataLogPath(path: Path, hadoopConf: Configuration, sqlConf:
SQLConf): Path = {
+ val metadataDir = new Path(path, FileStreamSink.metadataDir)
+ val fs = metadataDir.getFileSystem(hadoopConf)
+ FileStreamSink.checkEscapedMetadataPath(fs, metadataDir, sqlConf)
Review comment:
Oh sorry I should have explained before. That's to avoid test to copy
same code (logic) what FileStreamSink does, so that we don't break the test
when we somehow change it. Doesn't mean there's a bug in FileStreamSink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
