hvanhovell commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-651034649
@beliefer AFAIK the NTH_VALUE window function respects the frame specification you give it. Your PR currently only works for an unbounded frame (`UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING`). You could go two ways here: 1. Support all frames. In that case NTH_value should be an aggregate function, that just outputs the NTH observation. I think this is reasonable in the long run. 2. Only support unbounded frames. However, if you do, then we should improve the UX and have a proper error message in place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
