srowen commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r446997416
##########
File path:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala
##########
@@ -411,7 +411,7 @@ private[spark] object RestSubmissionClient {
// SPARK_HOME and SPARK_CONF_DIR are filtered out because they are usually
wrong
// on the remote machine (SPARK-12345) (SPARK-25934)
- private val BLACKLISTED_SPARK_ENV_VARS = Set("SPARK_ENV_LOADED",
"SPARK_HOME", "SPARK_CONF_DIR")
+ private val EXCLUDED_SPARK_ENV_VARS = Set("SPARK_ENV_LOADED", "SPARK_HOME",
"SPARK_CONF_DIR")
Review comment:
I see 'excluded', 'reject', 'inaccessible', etc used as new terms; the
idea is to use terms more specific to the usage? OK if so. Like sometimes it's
a list of things that are to be excluded, things that are inaccessible, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
