dongjoon-hyun commented on a change in pull request #28948:
URL: https://github.com/apache/spark/pull/28948#discussion_r447065712
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
##########
@@ -248,12 +248,17 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
* `HadoopFsRelation` node(s) as part of its logical plan.
*/
def recacheByPath(spark: SparkSession, resourcePath: String): Unit = {
- val (fs, qualifiedPath) = {
- val path = new Path(resourcePath)
- val fs = path.getFileSystem(spark.sessionState.newHadoopConf())
- (fs, fs.makeQualified(path))
- }
+ val path = new Path(resourcePath)
+ val fs = path.getFileSystem(spark.sessionState.newHadoopConf())
+ recacheByPath(spark, path, fs)
+ }
+ /**
+ * Tries to re-cache all the cache entries that contain `path` in one or more
+ * `HadoopFsRelation` node(s) as part of its logical plan.
+ */
+ def recacheByPath(spark: SparkSession, path: Path, fs: FileSystem): Unit = {
Review comment:
Just wondering if we can have a consistent parameter name for all
`recacheByPath`s. Currently, `resourcePath` and `path` are used in a mixed way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
