viirya commented on a change in pull request #28761:
URL: https://github.com/apache/spark/pull/28761#discussion_r447094702
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
##########
@@ -78,12 +78,16 @@ abstract class OrcTest extends QueryTest with
FileBasedDataSourceTest with Befor
(f: String => Unit): Unit = withDataSourceFile(data)(f)
/**
- * Writes `data` to a Orc file and reads it back as a `DataFrame`,
+ * Writes `df` dataframe to a Orc file and reads it back as a `DataFrame`,
* which is then passed to `f`. The Orc file will be deleted after `f`
returns.
*/
- protected def withOrcDataFrame[T <: Product: ClassTag: TypeTag]
- (data: Seq[T], testVectorized: Boolean = true)
- (f: DataFrame => Unit): Unit = withDataSourceDataFrame(data,
testVectorized)(f)
+ protected def withOrcDataFrame(df: DataFrame, testVectorized: Boolean = true)
Review comment:
I think it is for parity with the change at Parquet side (i.e.
`ParquetTest`) in #27728. It should look better if Parquet and Orc have the
same helper methods for test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
