sap1ens commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r447110243
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -135,7 +136,16 @@ class SessionCatalog(
private val tableRelationCache: Cache[QualifiedTableName, LogicalPlan] = {
val cacheSize = conf.tableRelationCacheSize
- CacheBuilder.newBuilder().maximumSize(cacheSize).build[QualifiedTableName,
LogicalPlan]()
+ val cacheTTL = conf.metadataCacheTTL
+
+ var builder = CacheBuilder.newBuilder()
+ .maximumSize(cacheSize)
+
+ if (cacheTTL > 0) {
Review comment:
Updated in
https://github.com/apache/spark/pull/28852/commits/18feeb02b11407b9eea1457139a91cb40ddc40cf,
now it says: ` This configuration only has an effect when this value having a
positive value (> 0)`, I think it's good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
