xkrogen commented on a change in pull request #28287:
URL: https://github.com/apache/spark/pull/28287#discussion_r447133442
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -289,13 +290,23 @@ private[spark] class ExecutorAllocationManager(
s" tasksperexecutor: $tasksPerExecutor")
val maxNeeded = math.ceil(numRunningOrPendingTasks *
executorAllocationRatio /
tasksPerExecutor).toInt
- if (tasksPerExecutor > 1 && maxNeeded == 1 && pendingSpeculative > 0) {
+ val totalNeed = if (tasksPerExecutor > 1 && maxNeeded == 1 &&
pendingSpeculative > 0) {
// If we have pending speculative tasks and only need a single executor,
allocate one more
// to satisfy the locality requirements of speculation
maxNeeded + 1
} else {
maxNeeded
}
+
+ // Request additional executors to schedule the unschedulable tasks as well
+ if (numUnschedulables > 0) {
+ val maxNeededForUnschedulables = math.ceil(numUnschedulables *
executorAllocationRatio /
+ tasksPerExecutor).toInt
+ math.max(totalNeed,
executorMonitor.executorCountWithResourceProfile(rpId)) +
+ maxNeededForUnschedulables
+ } else {
Review comment:
I think this should be:
```
math.max(totalNeed, executorMonitor.executorCountWithResourceProfile(rpId) +
maxNeededForUnschedules)
```
If we were already going to request `maxNeededForUnschedulables` _more_
executors than we currently have as part of `totalNeed`, that already satisfies
the requirements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
