holdenk commented on pull request #28864: URL: https://github.com/apache/spark/pull/28864#issuecomment-651420495
> > The only other thing is that the use of the Mesos API stands out. We could address that as well. Types could be renamed when imported, or we could create subclasses and use those. Similarly, we could create traits that implement the Mesos method name and call `agentLost` instead. > > Thanks for taking a look :) I think the type renames make sense, thanks for suggesting it. I think for the `agentLost` function we could just add it to `MesosSchedulerUtils` instead of adding a new trait. Turns out this didn't work out, since we uses MesosSchedulerUtils in some non-scheduler places. Added the new trait instead :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
