dilipbiswal commented on a change in pull request #28953:
URL: https://github.com/apache/spark/pull/28953#discussion_r447433000
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -122,6 +122,19 @@ object JdbcUtils extends Logging {
}
}
+ /**
+ * Runs a custom query against a table from the JDBC database.
+ */
+ def runQuery(conn: Connection, queryString: String, options: JDBCOptions):
Unit = {
+ val statement = conn.prepareStatement(queryString)
Review comment:
@moomindani Are we preventing user's to pass in "select queries" as part
of pre or post actions ? If they pass in a query, then would we get an result
set when we call "stme.execute()" that we need to free ?
Another question is , what happens when a post action fails ? We don't have
a notion of a transaction here, right ? In that case we probably need to
document our behavior ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
