Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5014#discussion_r26994637
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -142,7 +142,7 @@ case class CreateTableAsSelect[T](
         tableName: String,
         child: LogicalPlan,
         allowExisting: Boolean,
    -    desc: Option[T] = None) extends UnaryNode {
    +    desc: T) extends UnaryNode {
    --- End diff --
    
    The `CreateTableAsSelect` is designed as a common logical plan node, that's 
why I made the `desc` as `T`, and also the optional parameter. Otherwise, every 
SQL dialect will implements it's own `CTAS` node(logical plan).
    Or is the `CreateTableUsingAsSelect` a more generic interface for the same 
purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to