LantaoJin commented on a change in pull request #28935:
URL: https://github.com/apache/spark/pull/28935#discussion_r447548764



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2184,7 +2184,7 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
    * Create a Spark DataType.
    */
   private def visitSparkDataType(ctx: DataTypeContext): DataType = {
-    HiveStringType.replaceCharType(typedVisit(ctx))
+    
HiveVoidType.replaceVoidType(HiveStringType.replaceCharType(typedVisit(ctx)))

Review comment:
       For example,  below function will point the failure is due to the legacy 
hive void type. If we mix VOID and NULL, I am not sure it would be better than 
separation.
   ```scala
     def failVoidType(dt: DataType): Unit = {
       if (HiveVoidType.containsVoidType(dt)) {
         throw new AnalysisException(
           "Cannot create tables with Hive VOID type.")
       }
     }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to