AngersZhuuuu commented on a change in pull request #28805:
URL: https://github.com/apache/spark/pull/28805#discussion_r447610783



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
##########
@@ -108,4 +108,10 @@ class PruneFileSourcePartitionsSuite extends QueryTest 
with SQLTestUtils with Te
       }
     }
   }
+
+  override def getScanExecPartitionSize(query: String): Long = {
+    sql(query).queryExecution.sparkPlan.collectFirst {
+      case p: FileSourceScanExec => p
+    }.get.relation.location.inputFiles.length

Review comment:
       > this is not partitions number, but files number.
   > 
   > This should be `...relation.selectedPartitions.length`
   
   make FileSourceScanExec's selectedPartitions to be public like 
HiveTableScanExec's prunedPartitions will be ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to