frankyin-factual commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r447950809
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -178,11 +195,16 @@ object NestedColumnAliasing {
nestedFieldToAlias
.map { case (nestedField, _) =>
totalFieldNum(nestedField.dataType) }
.sum < totalFieldNum(attr.dataType)) {
- Some(attr.exprId -> nestedFieldToAlias)
+ Some((attr.exprId, nestedFieldToAlias))
} else {
None
}
}
+ .groupBy(_._1) // To fix same ExprId mapped to different attribute
instance
Review comment:
https://github.com/apache/spark/pull/28898/files#diff-957112380b0a2ef014abc8227d0b70acR479-R496
In this case, the attribute is `name`, but they have different qualifiers.
So the `groupBy` isn't quite working here. Then at the latter `flatMap`, it can
cause collision on the same `ExprId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
