ulysses-you commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r448055181
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -115,6 +116,26 @@ case class CreateTableLikeCommand(
CatalogTableType.EXTERNAL
}
+ // We only copy source tbl properties if the format is the same with each
other
+ val needCopyProperties =
+ (provider.isEmpty || provider == sourceTableDesc.provider) &&
Review comment:
`newProvider` checked `VIEW` and always used `parquet` as the provider.
We only copy properties for tables, and already checked at below code
```
val newProperties = sourceTableDesc.tableType match {
case MANAGED | EXTERNAL if needCopyProperties =>
// Hive only retain the useful properties through serde class
annotation.
// For better compatible with Hive, we remove the metastore
properties.
sourceTableDesc.properties --
DDLUtils.METASTORE_GENERATED_PROPERTIES ++ properties
case MANAGED | EXTERNAL =>
properties
case VIEW =>
// For view, we just use new properties
properties
case other =>
throw new IllegalArgumentException(
s"Unknown table type is found at createTableLikeCommand: $other")
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
