viirya commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r448057926
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -115,6 +116,26 @@ case class CreateTableLikeCommand(
CatalogTableType.EXTERNAL
}
+ // We only copy source tbl properties if the format is the same with each
other
+ val needCopyProperties =
+ (provider.isEmpty || provider == sourceTableDesc.provider) &&
Review comment:
Another case is `provider.isDefined` is false and
`fileFormat.inputFormat.isDefined` is true. We might copy properties for it if
`fileFormat.inputFormat == sourceTableDesc.storage.inputFormat`. Is it valid to
copy properties for this case? When the source provider is different to Hive
provider?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
