HeartSaVioR commented on a change in pull request #28941:
URL: https://github.com/apache/spark/pull/28941#discussion_r448081026
##########
File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
##########
@@ -1078,7 +1078,10 @@ private[spark] object JsonProtocol {
val blockManagerAddress = blockManagerIdFromJson(json \ "Block Manager
Address")
val shuffleId = (json \ "Shuffle ID").extract[Int]
val mapId = (json \ "Map ID").extract[Long]
- val mapIndex = (json \ "Map Index").extract[Int]
+ val mapIndex = (json \ "Map Index") match {
+ case JNothing => 0
Review comment:
Yeah that's valid concern, and caller may need to be prepared to handle
the invalid value. Why not we fix it for FOLLOW-UP PR? We have been doing it
even for nits. This doesn't even look to be a nit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
