LantaoJin commented on a change in pull request #28938:
URL: https://github.com/apache/spark/pull/28938#discussion_r448086615
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -213,23 +234,23 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
client.alterDatabase(dbDefinition)
}
- override def getDatabase(db: String): CatalogDatabase = withClient {
+ override def getDatabase(db: String): CatalogDatabase = withClient(db) {
client.getDatabase(db)
}
- override def databaseExists(db: String): Boolean = withClient {
+ override def databaseExists(db: String): Boolean = withClient(db) {
client.databaseExists(db)
}
- override def listDatabases(): Seq[String] = withClient {
+ override def listDatabases(): Seq[String] = withClient() {
Review comment:
I think we don't need a global lock for `listDatabases`. There are two
reasons. First is it is just a read operation, no critical problems except
getting dirty databases list. Second, the underlay store of HiveMetastore such
as MYSQL has locks itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
