cloud-fan commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r448110622
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/NullType.scala
##########
@@ -38,4 +38,12 @@ class NullType private() extends DataType {
* @since 1.3.0
*/
@Stable
-case object NullType extends NullType
+case object NullType extends NullType {
+
+ def containsNullType(dt: DataType): Boolean = dt match {
Review comment:
let's not add a new method to a stable public class. Can we put it in
the method `failNullType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
