HeartSaVioR commented on a change in pull request #28904:
URL: https://github.com/apache/spark/pull/28904#discussion_r448050453
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala
##########
@@ -106,10 +106,8 @@ abstract class CompactibleFileStreamLog[T <: AnyRef :
ClassTag](
interval
}
- /**
- * Filter out the obsolete logs.
- */
- def compactLogs(logs: Seq[T]): Seq[T]
+ /** Determine whether the log should be retained or not. */
+ def shouldRetain(log: T): Boolean
Review comment:
The UT I had to fix leverages this behavior - it's only possible when we
collect all entries, as it assumes DELETE_ACTION can come after ADD_ACTION "in
any further batches" and compactLogs should be able to filter out. This also
requires us to materialize all entries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
