prakharjain09 commented on a change in pull request #28924:
URL: https://github.com/apache/spark/pull/28924#discussion_r448190015
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -168,6 +173,37 @@ class BlockManagerMasterEndpoint(
stop()
}
+ private def handleFailure[T](
+ blockType: String,
+ blockId: String,
+ bmId: BlockManagerId,
+ defaultValue: T): PartialFunction[Throwable, T] = {
Review comment:
[nit] since this method deals with handling block removal failures
explicitly, can we rename it to reflect the same. maybe something like:
handleBlockRemovalFailure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
