LantaoJin commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r448252184
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -292,6 +293,8 @@ case class PreprocessTableCreation(sparkSession:
SparkSession) extends Rule[Logi
"in the table definition of " + table.identifier,
sparkSession.sessionState.conf.caseSensitiveAnalysis)
+ assertNoNullTypeInSchema(schema)
Review comment:
@cloud-fan
> Without this, "CREATE TABLE t1 USING PARQUET AS SELECT null as null_col"
in Spark will throw `Parquet data source does not support null data type.`
instead of `Cannot create tables with VOID type`
Sorry, above description is incorrect. Without this, CTAS for Hive table
`CREATE TABLE t2 AS SELECT null as null_col` will pass. No exception throws.
Seems Hive table (non-parquet/orc format) doesn't go through
`ResolveSessionCatalog`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
