gengliangwang commented on a change in pull request #28942:
URL: https://github.com/apache/spark/pull/28942#discussion_r448354522
##########
File path:
core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala
##########
@@ -96,8 +96,9 @@ private[v1] class StagesResource extends BaseAppResource {
@PathParam("stageAttemptId") stageAttemptId: Int,
@DefaultValue("0") @QueryParam("offset") offset: Int,
@DefaultValue("20") @QueryParam("length") length: Int,
- @DefaultValue("ID") @QueryParam("sortBy") sortBy: TaskSorting):
Seq[TaskData] = {
- withUI(_.store.taskList(stageId, stageAttemptId, offset, length, sortBy))
+ @DefaultValue("ID") @QueryParam("sortBy") sortBy: TaskSorting,
+ @QueryParam("status") statuses: JList[TaskStatus]): Seq[TaskData] = {
Review comment:
Why do we need to make it as array here? How about just `TaskStatus`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
