cloud-fan commented on a change in pull request #27900:
URL: https://github.com/apache/spark/pull/27900#discussion_r448383358
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/CatalogManagerSuite.scala
##########
@@ -108,6 +111,17 @@ class CatalogManagerSuite extends SparkFunSuite {
assert(v1SessionCatalog.getCurrentDatabase == "default")
catalogManager.setCurrentNamespace(Array("test2"))
assert(v1SessionCatalog.getCurrentDatabase == "default")
+
+ // Check namespace existence if currentCatalog implements
SupportsNamespaces.
+ conf.setConfString("spark.sql.catalog.dummyNamespace",
classOf[DummyNameSpaceCatalog].getName)
Review comment:
We can reuse `InMemoryTableCatalog` and create some namespaces before
testing `setCurrentNamespace`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
