cloud-fan commented on a change in pull request #28962:
URL: https://github.com/apache/spark/pull/28962#discussion_r448526240
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -123,7 +123,8 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
val fields = expr.dataType.asInstanceOf[StructType].fields.indices.map {
i =>
normalize(GetStructField(expr, i))
}
- CreateStruct(fields)
Review comment:
ah, got it!
This reminds me that we can optimize the code a bit: Instead of only
matching `CreateNamedStruct`, we can have a whitelist to apply the
normalization to the children. For example, `If(..., CreateNamedStruct(...))`,
we should apply normalization to the inner `CreateNamedStruct`.
We can do this later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
