maropu commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r448692070



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -176,9 +192,16 @@ object NestedColumnAliasing {
         // By default, ColumnPruning rule uses `attr` already.
         if (nestedFieldToAlias.nonEmpty &&
             nestedFieldToAlias
-              .map { case (nestedField, _) => 
totalFieldNum(nestedField.dataType) }
-              .sum < totalFieldNum(attr.dataType)) {
-          Some(attr.exprId -> nestedFieldToAlias)
+              .foldLeft(Seq[ExtractValue]()) {
+                (unique, curr) => if 
(!unique.exists(curr._1.semanticEquals(_))) {
+                  curr._1 +: unique
+                } else {
+                  unique
+                }
+              }
+              .map { t => totalFieldNum(t.dataType)  }
+              .sum < totalFieldNum(attr._2)) {

Review comment:
       Its hard to read this part. Could you pull the left value out from the 
`if` condition?
   ```
   val xxx = yyy
   if (xxx < totalFieldNum(attr._2)) { ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to