Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5149#discussion_r27007536
--- Diff: dev/merge_spark_pr.py ---
@@ -285,6 +286,56 @@ def resolve_jira_issues(title, merge_branches,
comment):
for jira_id in jira_ids:
resolve_jira_issue(merge_branches, comment, jira_id)
+def standardize_jira_ref(text):
+ # Standardize the [MODULE] SPARK-XXXXX prefix
--- End diff --
It would be pretty cool to add a doctest here. I've generally found
doctests to be pretty helpful when developing parsing / string manipulation
stuff like this, such as the pull request title parser that I wrote for
spark-prs.appspot.com:
https://github.com/databricks/spark-pr-dashboard/blob/0ee9102b7bb30fa61e2f47c3d282c5a018a7d198/sparkprs/utils.py#L55
Unfortunately, this script isn't well-structured to support doctests
because the main code isn't in a method. If you want to test this, we can move
the lines below this function (starting on 291/341) into a new main() function,
then call that from a `if __name__ == '__main__' block. It will blow up the
size of the diff a bit, but that's not a huge deal since we don't backport
changes to this file anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
