srowen commented on a change in pull request #28971:
URL: https://github.com/apache/spark/pull/28971#discussion_r448713930
##########
File path: core/src/main/scala/org/apache/spark/deploy/FaultToleranceTest.scala
##########
@@ -279,7 +279,7 @@ private object FaultToleranceTest extends App with Logging {
var liveWorkerIPs: Seq[String] = List()
def stateValid(): Boolean = {
- (workers.map(_.ip) -- liveWorkerIPs).isEmpty &&
+ workers.map(_.ip).forall(liveWorkerIPs.contains) &&
Review comment:
diff would work too, I think. It has multiset semantics, and I thought
it was not necessary here. I went for what I thought was simpler, but I am not
100% sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
