Gschiavon opened a new pull request #28984:
URL: https://github.com/apache/spark/pull/28984


   This is a WIP because I want to see what do you think about this.
   
   Now there is a `toJSON` function and I added `toJSON(options)` . I 
duplicated code now but the idea would be to have `toJSON()` and 
`toJSON(options)` so we could reuse all the code. The only problem is that 
adding the `()` to `toJSON` is a breaking change and I want to see what do you 
think about this.
   
   ### What changes were proposed in this pull request?
   Adding JSON Option for `toJSON` 
   
   
   ### Why are the changes needed?
   In order to be consistent with `to_json` and to be able to print null values 
when calling `toJSON`
   
   
   ### Does this PR introduce _any_ user-facing change?
   Depends, the idea would be to use the original `toJSON` but the function 
doesn`t accept parameters, and if I add them, could be a break change.
   
   ### How was this patch tested?
   Just added a test to show the use case
   
   Jira issue -> https://issues.apache.org/jira/browse/SPARK-32158
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to