beliefer commented on a change in pull request #27428:
URL: https://github.com/apache/spark/pull/27428#discussion_r449343562
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -216,15 +216,21 @@ abstract class AggregateFunction extends Expression {
def toAggregateExpression(): AggregateExpression =
toAggregateExpression(isDistinct = false)
/**
- * Wraps this [[AggregateFunction]] in an [[AggregateExpression]] and sets
`isDistinct`
- * flag of the [[AggregateExpression]] to the given value because
+ * Wraps this [[AggregateFunction]] in an [[AggregateExpression]] with
`isDistinct`
+ * flag and `filter` option of the [[AggregateExpression]] to the given
value because
* [[AggregateExpression]] is the container of an [[AggregateFunction]],
aggregation mode,
- * and the flag indicating if this aggregation is distinct aggregation or
not.
+ * the flag indicating if this aggregation is distinct aggregation or not
and filter option.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
