cloud-fan commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449454344



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
           case g: GroupingID =>
             failAnalysis("grouping_id() can only be used with 
GroupingSets/Cube/Rollup")
 
+          case Alias(w: WindowFunction, _) =>

Review comment:
       then the check doesn't work for cases like `rank() + 1`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to