HyukjinKwon commented on a change in pull request #28957:
URL: https://github.com/apache/spark/pull/28957#discussion_r449475633



##########
File path: python/pyspark/sql/types.py
##########
@@ -1487,36 +1451,14 @@ class Row(tuple):
     True
     """
 
-    # Remove after Python < 3.6 dropped, see SPARK-29748

Review comment:
       cc @BryanCutler to double check. Basically, I removed the logic here to 
don't sort keyword arguments by default, and removed `__from_dict__` related 
logics too (and setting the env in `run-tests.py` too)
   
   With Python 3.6+, it (already) broke few cases like 
https://github.com/apache/spark/pull/28957/files#diff-0590ca852e0e565bc489272aee36167fL890
 but I guess it's fine as discussed last time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to