maropu commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449714381
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,11 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with
GroupingSets/Cube/Rollup")
+ case e: Expression if
e.children.exists(_.isInstanceOf[WindowFunction]) &&
+ !e.isInstanceOf[WindowExpression] =>
Review comment:
nit: indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
