HeartSaVioR commented on pull request #28967: URL: https://github.com/apache/spark/pull/28967#issuecomment-653973297
I wonder we can link the spot on the JDK code (if it was from OpenJDK) so that we feel confident to remove the relevant test. I usually see the concern of removing tests, as the Spark codebase is quite complicated and in many cases UTs can only find the broken part. It tends to make us comfortable if the code is from JDK (or what we get rid of is actually what JDK is doing for us) but still be ideal which/where code it is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
