AngersZhuuuu commented on a change in pull request #27983:
URL: https://github.com/apache/spark/pull/27983#discussion_r449953588
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
##########
@@ -54,208 +51,170 @@ import org.apache.spark.util.{CircularBuffer,
RedirectThread, SerializableConfig
* @param script the command that should be executed.
* @param output the attributes that are produced by the script.
*/
-case class ScriptTransformationExec(
+case class HiveScriptTransformationExec(
input: Seq[Expression],
script: String,
output: Seq[Attribute],
child: SparkPlan,
ioschema: HiveScriptIOSchema)
- extends UnaryExecNode {
+ extends ScriptTransformBase {
override def producedAttributes: AttributeSet = outputSet -- inputSet
override def outputPartitioning: Partitioning = child.outputPartitioning
Review comment:
> We cannot move `producedAttributes` and `outputPartitioning` into the
base class?
Good suggestion， can move
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
