HyukjinKwon commented on a change in pull request #28983:
URL: https://github.com/apache/spark/pull/28983#discussion_r449977725
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/udaf.scala
##########
@@ -27,9 +27,12 @@ import
org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression
import
org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression,
Complete}
import
org.apache.spark.sql.catalyst.expressions.aggregate.{ImperativeAggregate,
TypedImperativeAggregate}
import
org.apache.spark.sql.catalyst.expressions.codegen.{GenerateMutableProjection,
GenerateSafeProjection}
+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.catalyst.rules.Rule
import org.apache.spark.sql.expressions.{Aggregator, MutableAggregationBuffer,
UserDefinedAggregateFunction}
import org.apache.spark.sql.types._
+
Review comment:
nit: I wouldn't change these newlines to make it easier to port it back
or revert in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
