HyukjinKwon commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r449991321
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ########## @@ -2623,8 +2625,16 @@ object Sequence { // about a month length in days and a day length in microseconds val intervalStepInMicros = stepMicros + stepMonths * microsPerMonth + stepDays * microsPerDay - val startMicros: Long = num.toLong(start) * scale - val stopMicros: Long = num.toLong(stop) * scale + + // Date to timestamp is not equal from GMT and Chicago timezones Review comment: Why do these codes depend on few specific timezones? Also, other comments look valid here. We should take the timezone into account for timestamps too ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org