Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/spark/pull/4708#discussion_r27068388
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -796,11 +802,12 @@ class DAGScheduler(
// First figure out the indexes of partition ids to compute.
val partitionsToCompute: Seq[Int] = {
- if (stage.isShuffleMap) {
- (0 until stage.numPartitions).filter(id => stage.outputLocs(id) ==
Nil)
- } else {
- val job = stage.resultOfJob.get
- (0 until job.numPartitions).filter(id => !job.finished(id))
+ stage match {
+ case stage: ShuffleMapStage =>
+ (0 until stage.numPartitions).filter(id => stage.outputLocs(id)
== Nil)
--- End diff --
Andrew - I think this one should be `.isEmpty` since it's looking for tasks
that haven't completed. I've replaced other comparisons to Nil in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
