srowen commented on a change in pull request #29008:
URL: https://github.com/apache/spark/pull/29008#discussion_r450244751
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala
##########
@@ -186,7 +186,7 @@ object RebaseDateTime {
.setTimeZone(TimeZoneUTC)
.setDate(localDate.getYear, localDate.getMonthValue - 1,
localDate.getDayOfMonth)
.build()
- Math.toIntExact(Math.floorDiv(utcCal.getTimeInMillis, MILLIS_PER_DAY))
+ Math.toIntExact(utcCal.getTimeInMillis, MILLIS_PER_DAY)
Review comment:
Yes, the comma needs to become a slash.
I think this change would then be OK as the sign of these two args are
always the same.
However, does it make much difference? it's going to be a few extra math
ops. It might be useful to just keep this consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
