warrenzhu25 commented on a change in pull request #28972:
URL: https://github.com/apache/spark/pull/28972#discussion_r450564054
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequests.scala
##########
@@ -54,6 +54,19 @@ class ExecutorResourceRequests() extends Serializable {
this
}
+ /**
+ * Specify off heap memory. The value specified will be converted to MiB.
Review comment:
When it's disabled, I should always return 0, and log warning when user
try to set this value. Is my understanding right? BTW, do you know how to
access sparkConf here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
