dilipbiswal commented on a change in pull request #28953:
URL: https://github.com/apache/spark/pull/28953#discussion_r450648679
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -122,6 +122,37 @@ object JdbcUtils extends Logging {
}
}
+ /**
+ * Runs a custom query against a table from the JDBC database.
+ */
+ def runQuery(conn: Connection, actions: String, options: JDBCOptions): Unit
= {
+ val autoCommit = conn.getAutoCommit
+ conn.setAutoCommit(false)
+ val queries = actions.split(";")
+ try {
+ queries.foreach { query =>
+ val queryString = query.trim()
+ val statement = conn.prepareStatement(queryString)
+ try {
+ statement.setQueryTimeout(options.queryTimeout)
+ val hasResultSet = statement.execute()
Review comment:
@moomindani The changes look reasonable to me. One small question. Read
the following :
```
JDBC drivers are not required to support this feature. You should use the
DatabaseMetaData.supportsBatchUpdates() method to determine if the
target database supports batch update processing. The method returns
true if your JDBC driver supports this feature.
```
at [link](https://www.tutorialspoint.com/jdbc/jdbc-batch-processing.htm)
So can we assume all the underlying JDBC implementations we have support this
feature ? As a start, we could just check
DatabaseMetaData.supportsBatchUpdates() and
raise an error saying pre and post actions are not supported ? Or we could
address it as
a follow-up ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
