attilapiros commented on a change in pull request #28967:
URL: https://github.com/apache/spark/pull/28967#discussion_r450727255
##########
File path:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
##########
@@ -145,29 +143,4 @@ public void jsonSerializationOfExecutorRegistration()
throws IOException {
assertEquals(shuffleInfo, mapper.readValue(legacyShuffleJson,
ExecutorShuffleInfo.class));
}
- @Test
- public void testNormalizeAndInternPathname() {
Review comment:
> but I'm afraid it's good direction we don't trust JDK implementation.
Let's assume JDK introduces a problem then the path is not totally
normalized but still that string is interned when you use this PR so you saved
the butes. Your normalized path could be even better
`java.io.FileSystem#normalize()` still the sole purpose of the
`createNormalizedInternedPathname` method is to save heap.
Regarding memory saving you are as good as close to get to
`java.io.FileSystem#normalize()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
