Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/5164#discussion_r27085539
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ZippedPartitionsRDD.scala ---
@@ -60,7 +60,7 @@ private[spark] abstract class ZippedPartitionsBaseRDD[V:
ClassTag](
val prefs = rdds.map(rdd =>
rdd.preferredLocations(rdd.partitions(i)))
// Check whether there are any hosts that match all RDDs; otherwise
return the union
val exactMatchLocations = prefs.reduce((x, y) => x.intersect(y))
- val locs = if (!exactMatchLocations.isEmpty) exactMatchLocations
else prefs.flatten.distinct
+ val locs = if (exactMatchLocations.nonEmpty) exactMatchLocations
else prefs.flatten.distinct
--- End diff --
`def isEmpty: Boolean = lengthCompare(0) == 0`
`def nonEmpty: Boolean = !isEmpty`
`!exactMatchLocations.isEmpty` equal `exactMatchLocations.nonEmpty`
nonEmpty maybe more clear semantically
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
