dongjoon-hyun commented on a change in pull request #28993:
URL: https://github.com/apache/spark/pull/28993#discussion_r451063160
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -46,10 +49,15 @@ class InMemoryTable(
private val allowUnsupportedTransforms =
properties.getOrDefault("allow-unsupported-transforms", "false").toBoolean
- partitioning.foreach { t =>
- if (!t.isInstanceOf[IdentityTransform] && !allowUnsupportedTransforms) {
- throw new IllegalArgumentException(s"Transform $t must be
IdentityTransform")
- }
+ partitioning.foreach {
+ case _: IdentityTransform =>
+ case _: YearsTransform =>
+ case _: MonthsTransform =>
+ case _: DaysTransform =>
+ case _: HoursTransform =>
+ case _: BucketTransform =>
+ case t if !allowUnsupportedTransforms =>
Review comment:
`allowUnsupportedTransforms` seems to be used only here and not by other
places (in InMemoryTable or in test suites). I'm wondering if we need this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
