dongjoon-hyun commented on a change in pull request #28833:
URL: https://github.com/apache/spark/pull/28833#discussion_r451107365
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2309,6 +2310,126 @@ class HiveDDLSuite
}
}
+ test("SPARK-20680: Spark-sql do not support for void column datatype") {
+ withTable("t") {
+ withView("tabVoidType") {
+ hiveClient.runSqlHive("CREATE TABLE t (t1 int)")
+ hiveClient.runSqlHive("INSERT INTO t VALUES (3)")
+ hiveClient.runSqlHive("CREATE VIEW tabVoidType AS SELECT NULL AS col
FROM t")
+ checkAnswer(spark.table("tabVoidType"), Row(null))
+ // No exception shows
+ val desc = spark.sql("DESC tabVoidType").collect().toSeq
+ assert(desc.contains(Row("col", NullType.simpleString, null)))
+ }
+ }
+
+ // Forbid CTAS with null type
+ withTable("t1", "t2", "t3") {
+ val e1 = intercept[AnalysisException] {
+ spark.sql("CREATE TABLE t1 USING PARQUET AS SELECT null as null_col")
+ }.getMessage
+ assert(e1.contains("Cannot create tables with unknown type"))
+
+ val e2 = intercept[AnalysisException] {
+ spark.sql("CREATE TABLE t2 AS SELECT null as null_col")
+ }.getMessage
+ assert(e2.contains("Cannot create tables with unknown type"))
+
+ val e3 = intercept[AnalysisException] {
+ spark.sql("CREATE TABLE t3 STORED AS PARQUET AS SELECT null as
null_col")
+ }.getMessage
+ assert(e3.contains("Cannot create tables with unknown type"))
+ }
+
+ // Forbid Replace table AS SELECT with null type
+ withTable("t") {
+ val v2Source = classOf[FakeV2Provider].getName
+ val e = intercept[AnalysisException] {
+ spark.sql(s"CREATE OR REPLACE TABLE t USING $v2Source AS SELECT null
as null_col")
+ }.getMessage
+ assert(e.contains("Cannot create tables with unknown type"))
+ }
+
+ // Forbid creating table with VOID type in Spark
Review comment:
For this line and the following, it looks correct because we parse
`VOID` in AstBuilder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
