dongjoon-hyun commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r451173748
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -278,4 +278,15 @@ object ResolveHints {
h.child
}
}
+
+ /**
+ * Removes all the hints when `spark.sql.ignorePlanHints` is set.
+ * This is executed at the very beginning of the Analyzer to disable
+ * the hint functionality.
+ */
+ class DisableHints(conf: SQLConf) extends RemoveAllHints(conf: SQLConf) {
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ if (conf.getConf(SQLConf.IGNORE_HINTS)) super.apply(plan) else plan
Review comment:
Hi, @dilipbiswal . It seems that he also meant`SQLConf.IGNORE_HINTS`
should be `SQLConf.DISABLE_HINTS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
