maropu commented on a change in pull request #29027:
URL: https://github.com/apache/spark/pull/29027#discussion_r451206786
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -132,9 +134,12 @@ object NestedColumnAliasing {
// If all nested fields of `attr` are used, we don't need to introduce
new aliases.
// By default, ColumnPruning rule uses `attr` already.
+ // Note that we need to remove cosmetic variations first, so we only
count a
+ // nested field once.
if (nestedFieldToAlias.nonEmpty &&
- nestedFieldToAlias
- .map { case (nestedField, _) =>
totalFieldNum(nestedField.dataType) }
+ nestedFields.map(_.canonicalized)
Review comment:
Ah, I missed this part. I think the added test still fails if we don't
have this change. Is this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
