Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5154#discussion_r27089272 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUdf.scala --- @@ -30,372 +30,423 @@ case class ScalaUdf(function: AnyRef, dataType: DataType, children: Seq[Expressi type EvaluatedType = Any def nullable = true - - override def toString = s"scalaUDF(${children.mkString(",")})" - + // scalastyle:off + + override def toString = s"scalaUDF(${children.mkString(",")})" /** This method has been generated by this script - (1 to 22).map { x => - val anys = (1 to x).map(x => "Any").reduce(_ + ", " + _) - val evals = (0 to x - 1).map(x => s" ScalaReflection.convertToScala(children($x).eval(input), children($x).dataType)").reduce(_ + ",\n " + _) + (1 to 22).map { x => --- End diff -- Nit: indention issues, we should keep 2 spaces instead of 4.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org