sarutak commented on a change in pull request #29029:
URL: https://github.com/apache/spark/pull/29029#discussion_r451260580
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
##########
@@ -198,7 +198,7 @@ object EvaluatePython {
case udt: UserDefinedType[_] => makeFromJava(udt.sqlType)
- case other => (obj: Any) => nullSafeConvert(other)(PartialFunction.empty)
+ case other => (obj: Any) => nullSafeConvert(obj)(PartialFunction.empty)
Review comment:
> btw, for any input, this converter in this pattern returns null?
Yes so it's difficult to test based on the return value.
Or, how about testing that the converter still returns null, meaning there
is no regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
