Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/4827#discussion_r27091991
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -170,8 +170,8 @@ class BlockManagerSuite extends FunSuite with Matchers
with BeforeAndAfterEach
assert(master.getLocations("a3").size === 0, "master was told about
a3")
// Drop a1 and a2 from memory; this should be reported back to the
master
- store.dropFromMemory("a1", null)
- store.dropFromMemory("a2", null)
+ store.dropFromMemory("a1", null: Either[Array[Any], ByteBuffer])
+ store.dropFromMemory("a2", null: Either[Array[Any], ByteBuffer])
--- End diff --
Yes. But I think we only use `null` in some unit tests, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
